(#86) Enforce permissions on created files #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silug
force-pushed
the
issue_86
branch
2 times, most recently
from
90802c4 to
43a6be6
Compare
bastelfreak
reviewed
Apr 27, 2022
bastelfreak
reviewed
Apr 27, 2022
silug
force-pushed
the
issue_86
branch
4 times, most recently
from
ef91e77 to
a3e7ffd
Compare
bastelfreak
reviewed
Apr 28, 2022
* Add attributes for enforcing ownership and permissions on created files * Add data types to all class and defined type parameters * Move documentation to Puppet Strings * Add generated REFERENCE.md * Add rspec tests for `kmod::option`, new parameters, etc. * Bump stdlib dependency to 5.0.0 (for `Stdlib::Filemode` type) Fixes voxpupuli#86
bastelfreak
reviewed
May 3, 2022
| ) { | ||
| include kmod |
There was a problem hiding this comment.
why did you add the include here?
There was a problem hiding this comment.
We need that to make sure that /etc/modprobe.d is managed.
bastelfreak
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kmod::option, new parameters, etc.Stdlib::Filemodetype)Fixes #86