Fix SELinux and add feature::api::bind_port support #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Jun 28, 2024
|
I removed the enhancement label. Our changelog generator puts PRs in categories based on labels. And it gets confused when it has to put a PR into two categories. |
|
I would prefer if we keep the "manage_selinux" switch, so the user has to make a decision and it reduces the impact of the change. What happens if the user runs icinga2 on a different port, with a diffent user etc.? |
|
Is there a reason to default manage_SELinux to true? |
SimonHoenscheid
requested changes
Jul 7, 2024
SimonHoenscheid
approved these changes
Jul 15, 2024
|
@lbetz pointed out in a private chat, this is still a draft. |
|
Now this PR only fixes problems with selinux on some file permissions and add support to change the bind_port of class icinga2::feature::api. |
lbetz
changed the title
SimonHoenscheid
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of SELinux. That mean the required policy package is installed if a selinux_package_name in globals is set and facts.os.selinux.enabled=true.