Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make object-collection deterministic in icinga2::query_objects #725

Merged
merged 1 commit into from
Mar 28, 2023
Merged

make object-collection deterministic in icinga2::query_objects #725

merged 1 commit into from
Mar 28, 2023

Conversation

sircubbi
Copy link
Contributor

Sort all objects by title, so the order will stable and not produce huge changesets by random chance.

Currently the order is random and will/might change between puppet runs.

@sircubbi
make object-collection deterministic in icinga2::query_objects
9d93c0a 
Sort all objects by title, so the order will stable and not produce huge
changesets by random chance.
@cla-bot cla-bot bot added the cla/signed label Mar 28, 2023
@sircubbi sircubbi mentioned this pull request Mar 28, 2023
Merged
@sircubbi
Copy link
Contributor Author

sircubbi commented Mar 28, 2023 •
edited
Loading

I created two different PRs (#724 and #725), because both address separate issues. Since you cannot merge both of them together, I will rebase once one of the both PRs have been accepted.

@lbetz lbetz added this to the v3.6.1 milestone Mar 28, 2023
@lbetz lbetz added the bug label Mar 28, 2023
@lbetz lbetz merged commit def5091 into voxpupuli:master Mar 28, 2023
@lbetz lbetz self-requested a review March 28, 2023 13:31
@sircubbi sircubbi deleted the deterministic_query_order branch March 28, 2023 13:34
sircubbi referenced this pull request Sep 9, 2023
@lbetz
remove title sort from query_objects
6610356
@lbetz lbetz mentioned this pull request Sep 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbetz lbetz Awaiting requested review from lbetz

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sircubbi @lbetz