Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added known issues regarding environment bleed to documentation #693

Conversation

zilchms
Copy link
Contributor

@zilchms zilchms commented Dec 6, 2021

Discussed in comments in #689

@cla-bot
Copy link

cla-bot bot commented Dec 6, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: markuszilch.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@zilchms zilchms force-pushed the fix/documentation-regarding-environmentbleed-689 branch from 235c822 to bf6b636 Compare December 6, 2021 12:33
@cla-bot cla-bot bot added the cla/signed label Dec 6, 2021
@rweigle
Copy link

rweigle commented Dec 6, 2021

Looks good!

@lbetz
Copy link
Contributor

lbetz commented Dec 6, 2021

Thx so much. Would it be correct to add puppet generate types --environment xxx to 2) as todo?

@rweigle
Copy link

rweigle commented Dec 6, 2021

I haven't checked the puppet documentation. In our case "Regenerate all resource types in case you are using environment isolation" was deleting the resources rm -rf /etc/puppetlabs/code/environment/xxx/.resource_types/ and puppet generate types --environment xxx. I'm not sure if the first step is necessary but probably it should be mentioned.

@lbetz lbetz added this to the v3.2.1 milestone Dec 6, 2021
@zilchms
Copy link
Contributor Author

zilchms commented Dec 6, 2021

I am in favor of doing it in your style @rweigle . We can split step 2 in the mentioned two steps. We should be on the saver side in your case.

@cla-bot
Copy link

cla-bot bot commented Dec 6, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: zilchms.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla/signed label Dec 6, 2021
@zilchms zilchms force-pushed the fix/documentation-regarding-environmentbleed-689 branch from a7676ef to 3a0d4e3 Compare December 6, 2021 15:40
@cla-bot cla-bot bot added the cla/signed label Dec 6, 2021
@zilchms zilchms force-pushed the fix/documentation-regarding-environmentbleed-689 branch from 1e85f54 to 67cefa9 Compare December 6, 2021 15:48
@lbetz lbetz merged commit 538b835 into voxpupuli:master Dec 17, 2021
@zilchms zilchms deleted the fix/documentation-regarding-environmentbleed-689 branch June 8, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants