Missing parameters #630
Merged
Missing parameters #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just check the Travis-ci, don't think that's related to the modification I propose |
|
... and what is with PluginContribDir? |
Without those parameters the module don't work under FreeBSD, the file
'constants.conf' created by the module don't get the PluginDir or
PluginContribDir, but the standard config for the plugin still get thing like
command = [ PluginDir + "/check_ping" ]
so icinga2 won't start because PluginDir/PluginContribDir are unkown
|
Le 01/10/2020 à 09:12:45-0700, Lennart Betz a écrit
... and what is with PluginContribDir?
You're 100% right. I just add it.
I put the same values as the constants.conf.sample come from the pkg.
In fact I already call the class with custom parameter for
PluginContribDir so I didn't see the bug.
Regards
|
|
Do you use icingaweb2 also on freebsd? Maybe I'd like to freebsd support to the module icingaweb2. |
|
Le 01/10/2020 à 10:25:45-0700, Lennart Betz a écrit
Do you use icingaweb2 also on freebsd? Maybe I'd like to freebsd support to the
module icingaweb2.
See voxpupuli/puppet-icingaweb2#210 .. but this pr is a little old.
Sorry.....currently I do not. We running a linux server and
debian/freebsd/windows(not in puppet)/centos clients.
Maybe in the futur, I have a nagios server running on FreeBSD I need to
switch to icinga2
If I do I will try to fix the problem and create a pull request.
|
|
Sounds quit good. |
lbetz
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this parameter the module don't work under FreeBSD, the file
'constants.conf' created by the module don't get the PluginDir, but
the standard config for the plugin still get thing like
so icinga2 won't start because PluginDir are unkown