Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing CA directory with known certificates #622

Closed
wants to merge 2 commits into from

Conversation

PedroMSantosD
Copy link

When creating an icinga master, but instead of letting icinga create its ca certificates, force the use of the certificates via hieradata, the ca.crt and ca.key can not be created unless the ${ca_dir} is created.
This PR allows declaring the ${ca_dir} on the ca module; so you can choose

  1. Not to set ca certificates, hence letting the module create new the new ca or
  2. Set ca certificates, hence creating the ca with the content passed via hiera to the module
    icinga2::pki::ca::ca_cert
    icinga2::pki::ca::ca_key

@lbetz lbetz self-requested a review July 6, 2020 14:08
@lbetz
Copy link
Contributor

lbetz commented Jul 6, 2020

file { $ca_dir:
  ensure => directory,
}

is enough, quoting isn't needed and the dependencies are redundant, because puppet has an implicit dependency between directories and their associated files.

@lbetz lbetz added this to the v3.0.0 milestone Jul 6, 2020
@lbetz lbetz added the bug label Jul 6, 2020
@lbetz lbetz changed the title enable creating CA with known certificates Managing CA directory with known certificates Jul 6, 2020
@lbetz lbetz closed this in 3e3f8a7 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants