Fix dependency issues with apt repository #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What version of the apt module you use? |
|
Currently 4.1.0. btw, i can't see why the tests are failing, any idea? |
|
ok, tests pass locally. This seems to be a problem with Travis. Can someone please commented/review this? |
This is needed as there is currently no dependency between the icinga2 packages and Class['apt::update']. This can lead to problems where the package is installed before apt knowns of the repository. It also removes the anchor usage of the icinga2::repo class and moves the dependency management to icinga::repo itself. This is needed as other modules might also add apt repositories and require Class['apt::update']. When using the anchor pattern this breaks as it introduces a dependency cycle.
baurmatt
force-pushed
the
fix-apt-dependency
branch
from
f118cde to
f18bad7
Compare
|
Rebased. Can someone review this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as there is currently no dependency between the
icinga2 packages and Class['apt::update']. This can lead to problems
where the package is installed before apt knowns of the repository.
It also removes the anchor usage of the icinga2::repo class and moves
the dependency management to icinga::repo itself. This is needed as
other modules might also add apt repositories and require
Class['apt::update']. When using the anchor pattern this breaks as
it introduces a dependency cycle.