Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OracleLinux #200

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Add support for OracleLinux #200

merged 2 commits into from
Jan 24, 2017

Conversation

TwizzyDizzy
Copy link
Contributor

@TwizzyDizzy TwizzyDizzy commented Jan 17, 2017 •
edited by bobapple
Loading

fixes #216

lazyfrosch
lazyfrosch approved these changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@lazyfrosch lazyfrosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobapple
Copy link
Contributor

Thanks for the effort @TwizzyDizzy
We need integration tests for this before merging. I can take care of this, but not before v1.0. Expect these changes to be merged after the 1.0 release

@TwizzyDizzy
Copy link
Contributor Author

Thanks for giving a rough estimate!

@bobapple bobapple self-assigned this Jan 23, 2017
@bobapple bobapple changed the base branch from master to feature/oraclelinux-support January 24, 2017 08:31
@bobapple bobapple merged commit 6da26a1 into voxpupuli:feature/oraclelinux-support Jan 24, 2017
@bobapple bobapple added this to the v1.0.2 milestone Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazyfrosch lazyfrosch lazyfrosch approved these changes

Assignees

@bobapple bobapple

Labels
None yet
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@TwizzyDizzy @bobapple @lazyfrosch