SLES should use service pack repository

[lazyfrosch]

SUSE Enterprise Linux uses Service Packs to release major updates for its base distribution.

While be built packages for the current supported releases, these releases are not compatible under each other.

Some changes between for example 12.2 und 12.3 are so major, that icinga2 packages need to be rebuilt explicitly for the target releases.

Now the module here uses a symlink we want to remove from the repository:

https://github.com/Icinga/puppet-icinga2/blob/87f1be2188926e481aafc14df0c03fd02c67c724/manifests/repo.pp#L94

This results in this URL to be used:

http://packages.icinga.com/SUSE/12/release/

This would actually break installation, if you are not on the same Service Pack, than what we are linking to. E.g. 12.2 installed on system, and 12.3 is current symlink.

Please change the line to use: (with escaped $ in Puppet)

http://packages.icinga.com/SUSE/$releasever/release/

This is also used in: https://packages.icinga.com/SUSE/ICINGA-release.repo

[lazyfrosch]

Same applies for puppet-icingaweb2, but the incompatibility problem will show up to icinga2