Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Management Behavoir for Repositories #6

Closed
fionera opened this issue Jan 11, 2021 · 5 comments
Closed

Change Management Behavoir for Repositories #6

fionera opened this issue Jan 11, 2021 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fionera
Copy link

fionera commented Jan 11, 2021

Currently when I include the class by enabling manage_repo, the epel Repo gets defined even when manage_epel is set to false. This collides with the following: https://forge.puppet.com/modules/puppet/epel

@lbetz lbetz self-assigned this Jan 11, 2021
@lbetz lbetz added the bug Something isn't working label Jan 11, 2021
@lbetz lbetz added this to the v1.0.4 milestone Jan 11, 2021
@lbetz lbetz changed the title Collision with epel: Yumrepo[epel] already defined Change Management Behavoir for Repositories Jan 11, 2021
@lbetz
Copy link
Contributor

lbetz commented Jan 11, 2021

Currently params like manage_epel always manage the repository resource and manage_* enable or disable the repo. Rework to manage the resources and NOT to enable/disable repos.

@lbetz
Copy link
Contributor

lbetz commented Jan 11, 2021

@fionera if you like you can test branch fix/manage-repos-6

@fionera
Copy link
Author

fionera commented Jan 11, 2021

I currently have it set to my fork but since you took the same approach it should be fine :) Thank you

@lbetz
Copy link
Contributor

lbetz commented Jan 11, 2021

Ok, of course I did more. Especially the same for the other supported plattforms.

I will perform acceptence tests and build a release tomorrow or maybe later today.

@fionera
Copy link
Author

fionera commented Jan 11, 2021

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants