Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart puppet master #71

Merged
merged 1 commit into from
Oct 12, 2015
Merged

restart puppet master #71

merged 1 commit into from
Oct 12, 2015

Conversation

vchepkov
Copy link
Contributor

@vchepkov vchepkov commented Jun 6, 2015

Puppet master needs to be restarted in order for hiera configuration changes to take effect

@hunner
Copy link
Member

hunner commented Jun 15, 2015

Ooo, I hadn't thought of using the collector and plusignment to make this work. Thanks!

@vchepkov
Copy link
Contributor Author

vchepkov commented Aug 7, 2015

It's got outdated for PE2015.2, but this module is essentially broken for this PE release anyway

# Restart master service
Service <| title == $hiera::params::master_service |> {
subscribe +> File[$hiera_yaml],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work if there's no master on the node?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, collector won't collect anything, since it won't find service in the
catalog

On Fri, Aug 7, 2015 at 10:38 AM, Igor Galić notifications@github.com
wrote:

In manifests/init.pp
https://github.com/hunner/puppet-hiera/pull/71#discussion_r36524825:

@@ -96,4 +96,8 @@
ensure => symlink,
target => $hiera_yaml,
}

  • Restart master service

  • Service <| title == $hiera::params::master_service |> {
  • subscribe +> File[$hiera_yaml],
  • }

will this work if there's no master on the node?


Reply to this email directly or view it on GitHub
https://github.com/hunner/puppet-hiera/pull/71/files#r36524825.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, is +> still in puppet 4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# /opt/puppetlabs/bin/puppet -V
4.2.1
# /opt/puppetlabs/bin/puppet apply test.pp 
Notice: Compiled catalog for localhost in environment production in 0.44 seconds
Notice: Applied catalog in 0.16 seconds
# cat test.pp 
file { '/etc/motd':
  ensure => present,
}

Service <| title == 'whatever' |> {
  subscribe +> File['/etc/motd'],
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh cool thanks

@igalic
Copy link
Contributor

igalic commented Aug 11, 2015

@vchepkov this still needs a rebase, though

@vchepkov
Copy link
Contributor Author

As I said, once this module adjusted to work properly on PE2015.2, I will redo the PR
There are some good fixes awaiting to be pulled in.

@vchepkov
Copy link
Contributor Author

vchepkov commented Oct 3, 2015

I have rebased my commit

@igalic
Copy link
Contributor

igalic commented Oct 4, 2015

@hunner get mergin

@hunner
Copy link
Member

hunner commented Oct 12, 2015

“You can use a special syntax called a collection, or you can arrange to have a firm and serious talk with Charles that very night.”

http://thedoomthatcametopuppet.tumblr.com/post/105622078297/you-can-use-a-special-syntax-called-a-collection

hunner added a commit that referenced this pull request Oct 12, 2015
@hunner hunner merged commit 93573cc into voxpupuli:master Oct 12, 2015
@vchepkov vchepkov deleted the restart branch January 15, 2016 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants