-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart puppet master #71
Conversation
Ooo, I hadn't thought of using the collector and plusignment to make this work. Thanks! |
It's got outdated for PE2015.2, but this module is essentially broken for this PE release anyway |
# Restart master service | ||
Service <| title == $hiera::params::master_service |> { | ||
subscribe +> File[$hiera_yaml], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work if there's no master on the node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, collector won't collect anything, since it won't find service in the
catalog
On Fri, Aug 7, 2015 at 10:38 AM, Igor Galić notifications@github.com
wrote:
In manifests/init.pp
https://github.com/hunner/puppet-hiera/pull/71#discussion_r36524825:@@ -96,4 +96,8 @@
ensure => symlink,
target => $hiera_yaml,
}
Restart master service
- Service <| title == $hiera::params::master_service |> {
- subscribe +> File[$hiera_yaml],
- }
will this work if there's no master on the node?
—
Reply to this email directly or view it on GitHub
https://github.com/hunner/puppet-hiera/pull/71/files#r36524825.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, is +> still in puppet 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# /opt/puppetlabs/bin/puppet -V
4.2.1
# /opt/puppetlabs/bin/puppet apply test.pp
Notice: Compiled catalog for localhost in environment production in 0.44 seconds
Notice: Applied catalog in 0.16 seconds
# cat test.pp
file { '/etc/motd':
ensure => present,
}
Service <| title == 'whatever' |> {
subscribe +> File['/etc/motd'],
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh cool thanks
@vchepkov this still needs a rebase, though |
As I said, once this module adjusted to work properly on PE2015.2, I will redo the PR |
I have rebased my commit |
…changes to take effect
@hunner get mergin |
|
Puppet master needs to be restarted in order for hiera configuration changes to take effect