Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key generation #37

Merged
merged 1 commit into from
Nov 21, 2014
Merged

Fix key generation #37

merged 1 commit into from
Nov 21, 2014

Conversation

emning
Copy link
Contributor

@emning emning commented Oct 26, 2014

This fixes eyaml key generation on Puppet open source, which would error out with messages like:

Error: Could not find command '/usr/bin/puppet/eyaml'

As the eyaml binary may be in one of several directories depending on both OS and which gem provider is in use, switch to using a search path, and make it configurable.

This should cover both #30 and #32, and also work on Ubuntu versions where gems end up in /usr/local/bin.

@igalic
Copy link
Contributor

igalic commented Oct 28, 2014

+1

shoekstra referenced this pull request in shoekstra/puppet-hiera Nov 17, 2014
@shoekstra
Copy link

This fixed it for me on Ubuntu.

One thing though, specifying the $hiera::cmdpath wouldn't do anything because $hiera::eyaml::cmdpath is being getting the value of $hiera::params::cmdpath.

Please could you update your PR to rectify this (either removing the inheritance as in my commit or by inheriting from the hiera class instead of hiera::params).

Cheers,
Stephen

@hunner hunner merged commit d52758c into voxpupuli:master Nov 21, 2014
hunner added a commit that referenced this pull request Nov 21, 2014
Fix key generation

Conflicts:
	manifests/init.pp
	manifests/params.pp
@emning emning deleted the fixcmdpath branch November 22, 2014 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants