Format options value as json if it is a hash #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroPointEnergy
force-pushed
the
support_hash_options
branch
from
d4a5ad8 to
f706647
Compare
|
thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins like hiera_vault have option values that are themself hashes. Currently the template will simply write this down as a string value, which leads to a broken configuration.
The implementation in this PR uses the fact that JSON is a valid subset of YAML. This may not look pretty as everything ends up on the same line, but it will always be valid.
I'm also not sure if it would be better to use the same methods if the value is an array, which could hold hashes as values as well and that isn't really handled correctly at the moment.
Let me know what you think.