Permission contention on hiera.yaml between module and PE #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
May 1, 2019
| } | ||
| else { | ||
| # It would probably be better to assume this is puppetserver, but that | ||
| # would be a backwards-incompatible change. |
There was a problem hiding this comment.
We're about to make one anyway when we drop support for puppet 4. Maybe this is a good time?
There was a problem hiding this comment.
I'm not opposed to it, but I'd really like to get a new version with this fix in immediately for the PE issue (it's restarting pe-puppetserver every 30 minutes because of this) and not worry about the backwards-incompatibility at the same time.
There was a problem hiding this comment.
ok. I'll call off 3.4.1 and we can do a 3.5.0 instead.
There was a problem hiding this comment.
Also, I should remember to use 'hide whitespace changes' more often to make it clear to me that this isn't something you had written...
alexjfisher
reviewed
May 1, 2019
alexjfisher
reviewed
May 1, 2019
|
@rnelson0 Are there any tests you'd like to add/modify? |
alexjfisher
approved these changes
May 1, 2019
rnelson0
changed the title
alexjfisher
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
Replaces #246
Sets better defaults for
/etc/hiera.yaml, eyaml keys, etc., to prevent conflict with the latest Puppet Enterprise versions.