modulesync 2.7.0 and drop puppet 4 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
Apr 23, 2019
There was a problem hiding this comment.
You've accidentally disabled most of the tests...
See
puppet-hiera/spec/classes/hiera_spec.rb
Line 312 in 8005064
|
@alexjfisher can you review this again? |
alexjfisher
reviewed
May 18, 2019
spec/classes/hiera_spec.rb
Outdated
| @@ -309,7 +309,7 @@ | |||
| it { is_expected.to contain_class('hiera::deep_merge') } | |||
| end | |||
| end | |||
| elsif Puppet.version =~ %r{^4} | |||
| elsif Puppet.version =~ %r{^6} | |||
There was a problem hiding this comment.
I think we should do more than just this. There's loads of dead tests that could be removed completely. If we're dropping puppet 4, maybe there's also code that should be cleared up and/or defaults that should be more sane.
There was a problem hiding this comment.
I dropped some of the legacy tests. Should we keep it as it is and merge it? We can raise an issue to cleanup the module later. That would allow us to move forward and release the module.
alexjfisher
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesync 2.7.0