Fix side affect in that the eyaml will always be first for backend lookups #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following seems not being applied: # the requested_backends has a side affect in that the eyaml will always be # first for backend lookups. This can be fixed by specifing the order in # the backends parameter ie. ['yaml', 'eyaml', 'redis'] When we specify an order: ```yaml hiera::backends: - consul - eyaml - yaml ``` eyaml is always included as first and the hiera.yaml generated comes as: ```yaml :backends: - eyaml - consul - yaml ``` The fix applied was to ignore the concat if eyaml is already present in the user defined backends.
preserve user defined backends
|
Thanks for the patch @mcmartins ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following seems not being applied:
When we specify an order:
eyaml is always included as first and the hiera.yaml generated comes as:
The fix applied was to ignore the concat if eyaml is already present in the user defined backends.