fail is not a resource type, it's a function. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sophomeric, thanks for the PR. Can you take a look at the failing spec tests? |
bastelfreak
added
bug
|
I really don't see what the issue is. My change was simple and the syntax is correct. Could it be related to this? |
|
And there's the fact that the syntax is bad as it is now without my change and fails to compile the catalog if you reach that code block. This conditionals intention (as I infer, not being the original author) is to produce a more intuitive error message for the user than the one puppet itself would give when the catalog fails. |
See: voxpupuli/puppet-lint-trailing_comma-check#4 By adding parenthesis around the conditional in the if statement we can get this to pass lint checks for now. Note that the puppet-lint bug is still a bug, and should be fixed in the puppet-lint project.
reidmv
approved these changes
Jul 11, 2017
bastelfreak
approved these changes
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.