Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata.json to not give dependency errors in puppet3.8 #142

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Update metadata.json to not give dependency errors in puppet3.8 #142

merged 1 commit into from
Aug 2, 2016

Conversation

cryptk
Copy link
Contributor

@cryptk cryptk commented Jul 21, 2016

On puppet3.8 there are dependency errors listed due to the use of hyphens rather than forward slashes in the metadata.json file:

root@testbox:/etc/puppet/modules/hiera# puppet module list
Warning: Missing dependency 'puppetlabs-inifile':
  'hunner-hiera' (v2.0.1) requires 'puppetlabs-inifile' (>= 1.0.0 < 2.0.0)
Warning: Missing dependency 'puppetlabs-stdlib':
  'hunner-hiera' (v2.0.1) requires 'puppetlabs-stdlib' (>= 4.3.1 < 5.0.0)
/etc/puppet/modules
├── hunner-hiera (v2.0.1)
├── puppetlabs-inifile (v1.5.0)
└── puppetlabs-stdlib (v4.12.0)

Altering the hyphens to forward slashes resolves this:

root@stackstorm:/etc/puppet/modules/hiera# puppet module list
/etc/puppet/modules
├── hunner-hiera (v2.0.1)
├── puppetlabs-inifile (v1.5.0)
└── puppetlabs-stdlib (v4.12.0)

I know that you guys like to have tests for fixes, but I am unsure how to write a test for problems such as this one...

@bastelfreak
Copy link
Member

Hey,

we're currently doing a modulesync in #143. This should fix the current errors in travis. Please rebase after #143 is merged, than I can merge your PR. No tests needed for this change.

@bastelfreak bastelfreak reopened this Jul 29, 2016
@bastelfreak
Copy link
Member

ups wrong button...

@igalic igalic merged commit ce9f950 into voxpupuli:master Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants