Modulesync #34
Merged
Modulesync #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniorsysadmin
force-pushed
the
modulesync
branch
from
c267207 to
f21c384
Compare
juniorsysadmin
force-pushed
the
modulesync
branch
from
f21c384 to
c5ced55
Compare
| @@ -5,7 +5,9 @@ | |||
| volume_ports = {} | |||
|
|
|||
| binary = Facter.value('gluster_custom_binary') | |||
| if not binary or not File.executable? binary | |||
| # rubocop:disable Style/AndOr | |||
There was a problem hiding this comment.
Probably a really simple fix, but rubocop-ignoring for now
| "version": "999.999.999", | ||
| "author": "Puppet Community", | ||
| "name": "puppet-gluster", | ||
| "version": "1.0.4", |
There was a problem hiding this comment.
(The last release in the previous namespace was 1.0.3)
|
This Pull Request is ready for review/merge |
|
Woohoo! Thanks @juniorsysadmin. This LGTM. After this is merged, please add puppet-gluster to modulesync_config's module list. |
|
Can this be rebased? |
juniorsysadmin
force-pushed
the
modulesync
branch
2 times, most recently
from
8d2909c to
a13a071
Compare
Perform a modulesync along with other minor changes
juniorsysadmin
force-pushed
the
modulesync
branch
from
a13a071 to
a3f566b
Compare
Done, with fixups to tests of #35 . Failures are due to something else (possibly PUP-5743) |
|
Merging. Please add this to modulesync_config. |
|
Ah. Did you keep the secret in .sync.yml? |
|
@jyaworski It didn't have a .travis.yml or a .sync.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform a modulesync along with other minor changes