Changed load paths for relative paths in firewalld_direct_purge.rb #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require 'puppet/type/firewalld_direct_passthrough' | ||
| require File.dirname(__FILE__).concat('/firewalld_direct_chain.rb') | ||
| require File.dirname(__FILE__).concat('/firewalld_direct_rule.rb') | ||
| require File.dirname(__FILE__).concat('/firewalld_direct_passthrough.rb') | ||
|
|
|
Fixed in firewalld_direct_purge.rb and firewalld_zone.rb. |
|
@vilkasx that looks great, thanks - will merge and release a patch shortly. |
|
This patch has been released as 3.1.2 on the forge... many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit should fix problem when puppet agent getting compiled catalogs from puppetdb. With 3.1.1 version of crayfishx-firewalld I've got following error:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Type-Name, Could not autoload puppet/type/firewalld_direct_purge: no such file to load -- puppet/type/firewalld_direct_chain at /etc/puppetlabs/code/environments/test_firewalld_module/modules/firewalld/manifests/init.pp:144:5