Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.2.0 #259

Closed
wants to merge 2 commits into from
Closed

Release 4.2.0 #259

wants to merge 2 commits into from

Conversation

ghoneycutt
Copy link
Member

No description provided.

@ghoneycutt
Copy link
Member Author

Followed https://voxpupuli.org/docs/releasing_version/ for my first release. The process is a bit confusing as https://voxpupuli.org/docs/releasing_version/ created a tag for v4.2.0 and pushed it, though the CHANGELOG is here and waiting for review. From the docs, I expected there to be a release pull request.

@ghoneycutt
Copy link
Member Author

Created voxpupuli/modulesync_config#641 to address the trailing whitespace in CHANGELOG.md.

This functionality exists in modulesync
@alexjfisher
Copy link
Member

Oops. The tag has been created on the wrong commit (where the metadata.json wasn't correct). I think the release task should have behaved better and refused to run.
The idea is that this release PR (including version number and changelog) would have been merged and then the release task run on the newly updated master.

@alexjfisher
Copy link
Member

Did you use the rake task to generate the changelog? That does some line ending fixup. https://github.com/voxpupuli/puppet-firewalld/blob/master/Rakefile#L72-L79

@alexjfisher
Copy link
Member

I think I'll get this release out as 4.2.1 and delete the errant tag. Hope this works for you?

@vox-pupuli-tasks
Copy link

Dear @ghoneycutt, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @ghoneycutt, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@alexjfisher
Copy link
Member

4.2.2 is now released. (4.2.1 failed due to an incorrect travis secret)

@alexjfisher
Copy link
Member

@ghoneycutt Sorry it didn't go so smoothly for you. Improvements to the docs are always welcome. They read 'ok' to me, but that's probably only because I've done it enough times.

@ghoneycutt ghoneycutt deleted the v420 branch February 17, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants