-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.2.0 #259
Release 4.2.0 #259
Conversation
Followed https://voxpupuli.org/docs/releasing_version/ for my first release. The process is a bit confusing as |
Created voxpupuli/modulesync_config#641 to address the trailing whitespace in CHANGELOG.md. |
This functionality exists in modulesync
Oops. The tag has been created on the wrong commit (where the metadata.json wasn't correct). I think the release task should have behaved better and refused to run. |
Did you use the rake task to generate the changelog? That does some line ending fixup. https://github.com/voxpupuli/puppet-firewalld/blob/master/Rakefile#L72-L79 |
I think I'll get this release out as 4.2.1 and delete the errant tag. Hope this works for you? |
Dear @ghoneycutt, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
Dear @ghoneycutt, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
4.2.2 is now released. (4.2.1 failed due to an incorrect travis secret) |
@ghoneycutt Sorry it didn't go so smoothly for you. Improvements to the docs are always welcome. They read 'ok' to me, but that's probably only because I've done it enough times. |
No description provided.