memoize self.state #241
Merged
memoize self.state #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are other places that call |
|
indeed, these checks are now superfluous. |
we memoize the output of check_running_state. this also helps clarify the name of the function self.check_running_state, which now no longer modifies a class-global variable, and instead just returns the state This pull Request is a Regression and is caused by #232 / #225 (which the author naïvely approved) Fixes #240
state is now memoized, so we don't need to call this function again Especially after we removed the side-effect from it!
|
what did 813141c do? |
alexjfisher
reviewed
Oct 31, 2019
this restores 813141c
|
No functional or idempotency issues noted during acceptance testing via simp/iptables. |
alexjfisher
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
we memoize the output of check_running_state.
this also helps clarify the name of the function
self.check_running_state, which now no longer modifies a class-globalvariable, and instead just returns the state
This pull Request is a Regression and is caused by #232 / #225 (which the author naïvely approved)
This Pull Request (PR) fixes the following issues
Fixes #240