Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reload after a create or destroy of a rich rule. #2

Merged
merged 2 commits into from
Apr 27, 2015
Merged

Add reload after a create or destroy of a rich rule. #2

merged 2 commits into from
Apr 27, 2015

Conversation

Z3r0Sum
Copy link
Contributor

@Z3r0Sum Z3r0Sum commented Apr 4, 2015

  • This activates the removal or creation right away.

@Z3r0Sum
Add reload after a create or destroy of a rich rule.
aee76fe 
  - This activates the removal or creation right away.
@crayfishx
Copy link
Contributor

Would it not make more sense and keep things simpler to just always run --reload in the firewall_cmd_run method, since this method only ever gets called for a creation or destroy ?

@Z3r0Sum
Update firewall_cmd.rb
fff1b37 
  - Since the firewall_cmd_run method is only called for creates and destroys, just do a reload every time.
@Z3r0Sum
Copy link
Contributor Author

Z3r0Sum commented Apr 24, 2015

I agree, it makes more sense to do it that way. I made the changes.

crayfishx added a commit that referenced this pull request Apr 27, 2015
@crayfishx
Merge pull request #2 from Z3r0Sum/firewall_reload
c4f73f1 
Add reload after a create or destroy of a rich rule.
@crayfishx crayfishx merged commit c4f73f1 into voxpupuli:master Apr 27, 2015
crayfishx pushed a commit that referenced this pull request Jun 13, 2018
@jfroche
Merge pull request #2 from jfroche/feature/purge-unknown-ipset
9b59f34 
Add option to remove unknown ipsets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Z3r0Sum @crayfishx