Allow puppetlabs-stdlib 6
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've applied this patch on my fork and encountered no issues. |
|
@crayfishx could you accept the merge request? |
|
Why does this MR change the name and summary of the module in the metadata.json file? I don't think that's what is intended? |
|
Rovanion, you are correct - that second commit was NOT meant to be part of this PR. Fixed now - thank you. |
alexjfisher
requested changes
May 30, 2019
Co-Authored-By: Alexander Fisher <alex@linfratech.co.uk>
|
@crayfishx ping! |
alexjfisher
changed the title
puppetlabs-stdlib 6
alexjfisher
approved these changes
Sep 20, 2019
|
👍 |
|
@jhoblitt Hi! I hope to get a new release out soon. Feel free to review any of the recent PRs I've opened. :) |
|
@alexjfisher I was hoping to just be a cheerleader for your efforts... :) I'm really short on time today but I did review or comment on the 5 latest PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191