Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default ensure to present #177

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Add default ensure to present #177

merged 1 commit into from
Jan 30, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Apr 26, 2018

For all types

@pgassmann
Copy link

pgassmann commented Jun 5, 2018 •
edited
Loading

What's missing for this pull request to be merged?

@jfroche Perhaps you can rebase the code, newest pull requests seem to pass the travis tests.

Edit: Wrong. it is the other way round

@crayfishx crayfishx added enhancement New feature or request accepted labels Jun 13, 2018
@crayfishx crayfishx added this to the 3.5.0 milestone Jun 13, 2018
@pccibot
Copy link

pccibot commented Sep 22, 2019

Dear @jfroche, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @jfroche, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@jfroche jfroche force-pushed the enhancement/add-default-ensure branch from 8b1c168 to 08c4f6b Compare January 23, 2020 11:13
@jfroche
Copy link
Contributor Author

jfroche commented Jan 23, 2020

rebased on master

igalic
igalic approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bastelfreak
Copy link
Member

thanks for the PR!

@bastelfreak bastelfreak merged commit adadb6b into voxpupuli:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
8 participants
@jfroche @pgassmann @pccibot @bastelfreak @igalic @alexjfisher @crayfishx @dhoppe