When defining a custom service & attaching to a zone - puppet errors and requires 2 runs

[DLV111]

This is an ordering issue - but i'm not sure how to fix it.

We need to ensure that the custom_services are all defined and a reload of the firewall-cmd is done - then you can proceed to add them to the defined zones.

[crayfishx]

@dlevene1 wouldn't you need to restart firewall-cmd again after you add them to the zones?

[DLV111]

Yep, but when you add a service it's not "seen" until you restart. So when
it's added to the zone it tries to add a service which it can't see yet and
fails, the next puppet run works fine. I can provide some error messages
and how to reproduce next week if that helps?
On 20 Nov 2015 5:58 pm, "Craig Dunn" notifications@github.com wrote:

@dlevene1 https://github.com/dlevene1 wouldn't you need to restart
firewall-cmd again after you add them to the zones?

—
Reply to this email directly or view it on GitHub
#27 (comment)
.

[jovandeginste]

@dlevene1 I think this is fixed with #30 - can you confirm?

[DLV111]

@jovandeginste I combined #30 and #31 in my tests and it all works as expected. I did noticed that on a custom zone the source's don't get applied until the second puppet run. See example below.

So apart from the 2 puppet runs, it all looks good.

[root@firewalld ~]# puppet agent -t
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for firewalld.levene
Info: Applying configuration version '1449619585'
Notice: /Stage[main]/Base::Firewalld_rules/Firewalld::Custom_service[nagios]/File[/etc/firewalld/services/nagios.xml]/ensure: created
Info: /Stage[main]/Base::Firewalld_rules/Firewalld::Custom_service[nagios]/File[/etc/firewalld/services/nagios.xml]: Scheduling refresh of Exec[firewalld::custom_service::reload-nagios]
Notice: /Stage[main]/Base::Firewalld_rules/Firewalld::Custom_service[nagios]/Exec[firewalld::custom_service::reload-nagios]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Base::Firewalld_rules/Firewalld_zone[ns_internal]/ensure: created
Info: /Stage[main]/Base::Firewalld_rules/Firewalld_zone[ns_internal]: Scheduling refresh of Exec[firewalld::reload]
Notice: /Stage[main]/Nsceph::Firewall::Ceph_server/Firewalld::Custom_service[Ceph Ports]/File[/etc/firewalld/services/ceph_ports.xml]/ensure: created
Info: /Stage[main]/Nsceph::Firewall::Ceph_server/Firewalld::Custom_service[Ceph Ports]/File[/etc/firewalld/services/ceph_ports.xml]: Scheduling refresh of Exec[firewalld::custom_service::reload-Ceph Ports]
Notice: /Stage[main]/Nsceph::Firewall::Ceph_server/Firewalld::Custom_service[Ceph Ports]/Exec[firewalld::custom_service::reload-Ceph Ports]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Nsceph::Firewall::Ceph_server/Firewalld_service[ceph_server-ceph_ports]/ensure: created
Info: /Stage[main]/Nsceph::Firewall::Ceph_server/Firewalld_service[ceph_server-ceph_ports]: Scheduling refresh of Exec[firewalld::reload]
Notice: /Stage[main]/Base::Firewalld_rules/Firewalld_service[ns_internal-ssh]/ensure: created
Info: /Stage[main]/Base::Firewalld_rules/Firewalld_service[ns_internal-ssh]: Scheduling refresh of Exec[firewalld::reload]
Notice: /Stage[main]/Base::Firewalld_rules/Firewalld_service[ns_internal-nagios]/ensure: created
Info: /Stage[main]/Base::Firewalld_rules/Firewalld_service[ns_internal-nagios]: Scheduling refresh of Exec[firewalld::reload]
Notice: /Stage[main]/Firewalld/Exec[firewalld::reload]: Triggered 'refresh' from 4 events
Notice: Finished catalog run in 90.00 seconds

[root@firewalld ~]# puppet agent -t
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for firewalld.levene
Info: Applying configuration version '1449619717'
Notice: /Stage[main]/Base::Firewalld_rules/Firewalld_zone[ns_internal]/sources: sources changed '[]' to '[10.10.10.0/24, 1234:4567:111::/48, 1234:4567:112::/48, 10.10.11.0/20]'
Info: /Stage[main]/Base::Firewalld_rules/Firewalld_zone[ns_internal]: Scheduling refresh of Exec[firewalld::reload]
Notice: /Stage[main]/Firewalld/Exec[firewalld::reload]: Triggered 'refresh' from 1 events
Notice: Finished catalog run in 62.23 seconds

[crayfishx]

@dlevene1 #71 should solve this issue for you

[DLV111]

Thanks Craig! I might wait until the discussion on issue/26 is complete
before I test this in our environment as both components have value to me.

On 13 August 2016 at 18:12, Craig Dunn notifications@github.com wrote:

@dlevene1 https://github.com/dlevene1 #71
#71 should solve this
issue for you

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKENZLrRlme0k-vgk1VZYF5-I37gbnf7ks5qfYN7gaJpZM4GmFtA
.

[crayfishx]

Released in 3.1.0