The module has a SERVER-94 loading issue

[trevor-vaughan]

The firewalld code has a SERVER-94 environment loading issue due to adding code to the PuppetX global module space in Ruby.

I have a guide on mitigating this posted at https://www.onyxpoint.com/fixing-the-client-side-of-multi-tenancy-in-the-puppet-server/.

Since this is simply code loaded in the Type, it may be simpler to move it into the Type namespace itself.

As it stands, any use of the existing code in multiple environments may result in unreliable behavior if the code in the PuppetX space is ever modified.

[igalic]

Since this is simply code loaded in the Type, it may be simpler to move it into the Type namespace itself.

👍

[alexjfisher]

In general, are custom parent properties/parameters considered evil?

[trevor-vaughan]

Not that I know of. Things loaded into global Ruby-space just have to be treated with care per my blog post.

[alexjfisher]

If you disregard the environment bleeding issue, the parent properties look elegant. By the time you go all meta-programming to make them environment safe, perhaps not so elegant anymore.