Make the position parameter work properly #4
Conversation
|
Changes Unknown when pulling 5a87fbf on mmarod:fix_position into * on hercules-team:master*. |
2 similar comments
|
Changes Unknown when pulling 5a87fbf on mmarod:fix_position into * on hercules-team:master*. |
|
Changes Unknown when pulling 5a87fbf on mmarod:fix_position into * on hercules-team:master*. |
| @@ -131,6 +131,31 @@ | |||
| :arguments => ["try_first_pass","retry=3","type="],}) | |||
| end | |||
|
|
|||
| describe "when reodering settings" do | |||
| it "Changing the order of an entry" do | |||
There was a problem hiding this comment.
I would rather this says "should change the order of an entry"
|
Changes Unknown when pulling bda708f on mmarod:fix_position into * on hercules-team:master*. |
| if PAM_POSITION_ALIASES[key].has_key? identifier | ||
| expr = PAM_POSITION_ALIASES[key][identifier] | ||
| expr = key ? expr % [type, value] : expr % [type] | ||
| else |
There was a problem hiding this comment.
I might have liked to keep the comment that was in the original piece of code here.
|
Thanks for the changes. Can you just fix the details I pointed out and squash please? |
…arameter would work.
|
Changes Unknown when pulling 50667f4 on mmarod:fix_position into * on hercules-team:master*. |
1 similar comment
|
Changes Unknown when pulling 50667f4 on mmarod:fix_position into * on hercules-team:master*. |
|
Changes Unknown when pulling 50667f4 on mmarod:fix_position into * on hercules-team:master*. |
|
Merged, thank you. |
|
Changes Unknown when pulling 50667f4 on mmarod:fix_position into * on hercules-team:master*. |
This fixes issue #3 by adding self.position_path and in_position? methods to the provider.