-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add array of headers as optional parameter #475
add array of headers as optional parameter #475
Conversation
This reverts commit 0d286d8.
linting update in-line puppet strings documentation added tests for passing headers update readme documentation trailing whitespace in README remove faraday-retry fix docs remove spurious string comment from spec
add ubuntu 22.04
@bastelfreak & @kenyon - was able to finish (I believe) #463 and re-request review. The acceptance test on
|
Ah here you fixed the escape problem. I guess the issue on arch linux is that wget isn't installed by default in the docker image. you could do something like |
switch to URI::RFC2396_Parser added headers as optional param linting update in-line puppet strings documentation added tests for passing headers update readme documentation delete trailing whitespace in README remove faraday-retry fix docs remove spurious string comment from spec remove duplicate elsif add wget package resource
Thank you for the suggestion! It worked like a charm! These most recent tests will pass.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's ready to merge
Is there anything I need to do to help this one get bumped up in priority? My current engagement has some unusual requirements about pointing to things that aren't tags from forge... They keep asking me for updates and I don't have any. :) |
thanks for all the work! |
linting
update in-line puppet strings documentation
added tests for passing headers
update README for headers
add Ubuntu 22.04 to metadata
rebase 'modulesync 5.3.0' work
Pull Request (PR) description
add headers param, update tests and documentation (strings, readme)
incorporate modulesync #463
This Pull Request (PR) fixes the following issues
Fixes #265
Fixes #445
Fixes #476
Finishes #463