Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add array of headers as optional parameter #475

Merged
merged 18 commits into from
Nov 23, 2022
Merged

add array of headers as optional parameter #475

merged 18 commits into from
Nov 23, 2022

Conversation

prolixalias
Copy link
Contributor

@prolixalias prolixalias commented Nov 3, 2022

linting

update in-line puppet strings documentation

added tests for passing headers

update README for headers

add Ubuntu 22.04 to metadata

rebase 'modulesync 5.3.0' work

Pull Request (PR) description

add headers param, update tests and documentation (strings, readme)

incorporate modulesync #463

This Pull Request (PR) fixes the following issues

Fixes #265
Fixes #445
Fixes #476
Finishes #463

manifests/artifactory.pp Outdated Show resolved Hide resolved
spec/unit/puppet/provider/archive/curl_spec.rb Outdated Show resolved Hide resolved
@prolixalias prolixalias requested a review from kenyon November 3, 2022 21:03
linting

update in-line puppet strings documentation

added tests for passing headers

update readme documentation

trailing whitespace in README

remove faraday-retry

fix docs

remove spurious string comment from spec
add ubuntu 22.04
@prolixalias prolixalias requested a review from kenyon November 4, 2022 14:11
@prolixalias
Copy link
Contributor Author

prolixalias commented Nov 4, 2022

@bastelfreak & @kenyon - was able to finish (I believe) #463 and re-request review. The acceptance test on archlinuxrolling seems to be a problem. I'm happy to assist on that one too. However, it looks like that's in another repo. Should I take a stab at it or is there more to it (that failure) than meets the eye?

Provider wget is not functional on this host

@bastelfreak
Copy link
Member

Ah here you fixed the escape problem. I guess the issue on arch linux is that wget isn't installed by default in the docker image. you could do something like package { 'wget': ensure => 'installed' } in the acceptancetest to ensure it's always installed.

switch to URI::RFC2396_Parser

added headers as optional param

linting

update in-line puppet strings documentation

added tests for passing headers

update readme documentation

delete trailing whitespace in README

remove faraday-retry

fix docs

remove spurious string comment from spec

remove duplicate elsif

add wget package resource
@prolixalias
Copy link
Contributor Author

Ah here you fixed the escape problem. I guess the issue on arch linux is that wget isn't installed by default in the docker image. you could do something like package { 'wget': ensure => 'installed' } in the acceptancetest to ensure it's always installed.

Thank you for the suggestion! It worked like a charm! These most recent tests will pass....

Copy link
Contributor Author

@prolixalias prolixalias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's ready to merge

@prolixalias
Copy link
Contributor Author

Is there anything I need to do to help this one get bumped up in priority? My current engagement has some unusual requirements about pointing to things that aren't tags from forge... They keep asking me for updates and I don't have any. :)

@bastelfreak bastelfreak changed the title added headers param (array) add array of headers as optional parameter Nov 23, 2022
@bastelfreak
Copy link
Member

thanks for all the work!

@bastelfreak bastelfreak merged commit 6c05ef3 into voxpupuli:master Nov 23, 2022
@bastelfreak bastelfreak added the enhancement New feature or request label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants