Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add archives parameter to make use with an ENC or hiera easier #423

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Add archives parameter to make use with an ENC or hiera easier #423

merged 1 commit into from
Oct 24, 2020

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Oct 21, 2020

Pull Request (PR) description

This PR adds a parameter to make generating archive requests from an ENC easier.

alexjfisher
alexjfisher requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'm not against adding this functionality, but it currently has a syntax error.

manifests/init.pp Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@jcpunk jcpunk requested a review from alexjfisher October 21, 2020 18:43
alexjfisher
alexjfisher reviewed Oct 22, 2020
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
@alexjfisher alexjfisher changed the title Add parameter to make use with an ENC easier Add archives parameter to make use with an ENC easier Oct 23, 2020
@alexjfisher alexjfisher added the enhancement New feature or request label Oct 23, 2020
@kenyon
Copy link
Member

kenyon commented Oct 23, 2020

Isn't this for hiera, not an ENC?

@alexjfisher
Copy link
Member

Isn't this for hiera, not an ENC?

either.

@alexjfisher alexjfisher changed the title Add archives parameter to make use with an ENC easier Add archives parameter to make use with an ENC or hiera easier Oct 23, 2020
@alexjfisher alexjfisher merged commit a034170 into voxpupuli:master Oct 24, 2020
@jcpunk jcpunk deleted the enc-args branch October 24, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcpunk @kenyon @alexjfisher