Bump stdlib dependency to <6.0.0 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelenCampbell
changed the title
|
@bastelfreak Hey Tim, If you get a chance would you have a look at this? We'll also need a release to get everything up and running again. If I can help at all give me a shout :) Thanks! |
juniorsysadmin
approved these changes
Aug 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Due to the new stdlib release of 5.0.0, this needs it's dependency bumped to < 6.0.0. We also will need a release of this module to fix breakages being seen in other modules.
This Pull Request (PR) fixes the following issues
This is the error we are getting on java:
An error occurred while loading ./spec/acceptance/install_spec.rb. Failure/Error: install_module_dependencies_on(hosts) Beaker::Host::CommandFailure: Host 'ubuntu-1404-x64' exited with 1 running: puppet module install puppet-archive -v 3.1.1 Last 10 lines of output were: Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ... Notice: Downloading from https://forgeapi.puppet.com ... Error: Could not install module 'puppet-archive' (???) No version of 'puppet-archive' can satisfy all dependencies Usepuppet module install --ignore-dependenciesto install only this module