Remove deprecated archive::artifactory parameters #322
Conversation
|
I would like to get this in before converting the artifactory_sha1 function to the puppet 4 API. As removing the deprecated parameters is already a breaking change, the function migration will probably be too (eg. I'll probably namespace it) |
manifests/artifactory.pp
Outdated
| @@ -43,12 +40,9 @@ | |||
| # } | |||
| # | |||
| define archive::artifactory ( | |||
| Pattern[/^https?:\/\//] $url, | |||
manifests/artifactory.pp
Outdated
| @@ -9,9 +9,6 @@ | |||
| # * path: fully qualified filepath for the download the file or use archive_path and only supply filename. (namevar). | |||
| # * ensure: ensure the file is present/absent. | |||
| # * url: artifactory download url filepath. NOTE: replaces server, port, url_path parameters. | |||
There was a problem hiding this comment.
Is the note still relevant? Maybe better to do that in the changelog?
manifests/artifactory.pp
Outdated
| @@ -71,44 +65,29 @@ | |||
| fail("archive::artifactory[${name}]: \$name or \$archive_path must be an absolute path!") # lint:ignore:trailing_comma | |||
There was a problem hiding this comment.
Odd lint ignore here. Also wondering if we should move the above line to just Stdlib::Absolutepath
There was a problem hiding this comment.
I tried removing the lint, and puppet-lint does complain. A false positive I guess.
Maybe I should use assert_type instead.
There was a problem hiding this comment.
I've updated this code to use assert_type and Stdlib::Absolutepath
The following parameters were deprecated a long time ago and have now been removed. * `server` * `port` * `url_path` Removing them is a breaking change but hopefully most users are already using `url`
alexjfisher
force-pushed
the
remove_deprecated_params_from_artifactory_sha1_function
branch
from
a36e997 to
636bb67
Compare
The following parameters were deprecated a long time ago and have now
been removed.
serverporturl_pathRemoving them is a breaking change but hopefully most users are already
using
url