Support Nexus 3 urls for artifact downloads #285
Conversation
|
@alexjfisher @nanliu Can someone look at this PR? 😄 |
| } else { | ||
| $c = '' | ||
| } | ||
| $artifact_url = sprintf('%s/repository/%s/%s/%s/%s/%s-%s%s.%s', $url, |
There was a problem hiding this comment.
Can any of the parameters, (artifact_id, version etc), contain characters that would need escaping when building a URL?
There was a problem hiding this comment.
They can (but shouldn't). It would be very unusual to have, say, a space in one of the parameters.
There was a problem hiding this comment.
A slash should never be in any of the parameters. Either way, if there is a slash and it's escaped you'd get a 404 and if it's not escaped, you'd also get a 404.
But if you're being silly and you specify the group_id with slashes (nl/avisi/foo instead of nl.avisi.foo) - escaping the slash will actually break the url.
manifests/nexus.pp
Outdated
| @@ -43,6 +43,7 @@ | |||
| Optional[String] $proxy_server = undef, | |||
| Optional[String] $proxy_type = undef, | |||
| Optional[Boolean] $allow_insecure = undef, | |||
| Optional[Boolean] $use_nexus3_urls = false, | |||
There was a problem hiding this comment.
No need for 'Optional' here as you're not defaulting to 'undef'
|
@rvdh Thanks for making that change. Could you rebase/squash down to a single commit? |
Nexus 3 no longer supports the old url format.
|
@alexjfisher Ofcourse, done! Thanks for taking the time to review. |
|
Hi, Is there a reason this is not merged yet? |
|
@zipkid Thanks. |
Support Nexus 3 urls for artifact downloads
Nexus 3 no longer supports the old url format.