Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters out the configured bundler path #583

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Filters out the configured bundler path #583

merged 1 commit into from
Jul 25, 2019

Conversation

logicminds
Copy link
Contributor

Without this change simplecov shows reports for all the gems
underneath the configured bundle path.

@logicminds
Filters out the configured bundler path
f3b2a39 
Without this change simplecov shows reports for all the gems 
underneath the configured bundle path.
alexjfisher
alexjfisher approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit! :) (aka LGTM, but I’ve not tested it. Can’t see how it could hurt though)

@bastelfreak
Copy link
Member 

[1] pry(main)> require 'bundler'
=> true
[2] pry(main)> puts Bundler.configured_bundle_path.path
vendor/bundle/ruby/2.6.0
=> nil
[3] pry(main)>

@bastelfreak bastelfreak merged commit 5e3ff0e into master Jul 25, 2019
@bastelfreak bastelfreak deleted the logicminds-patch-1 branch July 25, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@logicminds @bastelfreak @alexjfisher