Clean Rakefile.erb #565
Merged
Clean Rakefile.erb #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we stopped storing beaker nodesets as files in our modules, this task no longer makes sense.
No module uses this and it only complicates our Rakefile.
This removes all the duplication that already happens in puppetlabs_spec_helper. It also renamed extra_disabled_lint_checks to a more saner puppet_lint_checks. This is safe because no module actually uses this. It's sanfer because disabled implies we're actually disabling them for you.
While it's a duplication, our task actually has a better self-documenting name.
By always defining a default we can simplify our code and the defaults become a reference documentation.
bastelfreak
requested changes
Apr 6, 2019
bastelfreak
approved these changes
Apr 6, 2019
|
Re exclude_paths. Why do we overwrite those configured by puppetlabs_spec_helper? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dacad9a Simplify the exclude_paths logic
By always defining a default we can simplify our code and the defaults become a reference documentation.
623a46b Reuse the puppetlabs_spec_helper lint_fix task
While it's a duplication, our task actually has a better self-documenting name.
702ad3e Simplify lint configuration
This removes all the duplication that already happens in puppetlabs_spec_helper.
It also renamed extra_disabled_lint_checks to a more saner puppet_lint_checks. This is safe because no module actually uses this. It's sanfer because disabled implies we're actually disabling them for you.
06be76b Hard alias test to release checks
No module uses this and it only complicates our Rakefile.
586f9f1 Remove beaker_sets task
Since we stopped storing beaker nodesets as files in our modules, this task no longer makes sense.