Remove duplicate metadata_lint check #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Jan 11, 2019
Since puppetlabs_spec_helper 1.1.0 this has been part of the validate task. Validate is part of release_checks.
ekohl
force-pushed
the
remove-duplicate-lint
branch
from
3578470 to
ae59143
Compare
|
Btw, puppetlabs/puppet-strings#192 is similar, but doesn't allow overriding the pattern via the config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since puppetlabs_spec_helper 1.1.0 this has been part of the validate task. Validate is part of release_checks.
It's also possible to fully remove this mechanism since no module appears to be using it. We can just standardize on release_checks instead of our custom task test but I chose the simple way here.