rework forge API handling #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
approved these changes
Dec 27, 2018
binford2k
approved these changes
Dec 27, 2018
ekohl
reviewed
Dec 27, 2018
bin/get_all_the_diffs
Outdated
| while not mods.next_url.nil? | ||
| mods = mods.next | ||
| puts "we discovered another #{mods.count} modules on the forge" if DEBUG | ||
| forge_releases.concat(mods.map{|mod| mod.slug }) |
There was a problem hiding this comment.
Can also be written as mods.map(&:slug)
ekohl
reviewed
Dec 27, 2018
bin/get_all_the_diffs
Outdated
|
|
||
| vp = PuppetForge::User.find('puppet') | ||
| mods = vp.modules | ||
| forge_releases = mods |
There was a problem hiding this comment.
https://github.com/puppetlabs/forge-ruby#paginated-collections suggests you can also iterate automatically:
forge_releases = vp.modules.unpaginated.map(&:slug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.