Various improvements to the spec_helper #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 6, 2018
| @@ -1,3 +1,8 @@ | |||
| <%- if @configs['mock_with'] -%> | |||
| RSpec.configure do |c| | |||
| c.mock_with <%= @configs['mock_with'] %> | |||
There was a problem hiding this comment.
this block is now duplicate. We probably can remove the other one. This need to be tested within one module
There was a problem hiding this comment.
I just verified this on puppet-mongodb (in my local branch) that the later one is indeed redundant and it must be done here at the top.
ekohl
changed the title
|
Updated to include various updates. See the individual commits for details. |
|
can you please run this against one module and link the PR to this one? |
Otherwise it won't be used
Since rspec-puppet-facts 1.1.0 puppetversion is set. The facter version is set since 1.8.0. The concat_basedir fact isn't used since puppetlabs-concat 2.0.
This recommended in the current rspec-puppet README and ensures that the report covers all parallel spec workers.
The file has a .rb extension so this should be autodetected by any decent vim setup.
|
voxpupuli/puppet-nginx#1264 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it won't be used