bump ruby 2.4.2->2.4.3 #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Jan 28, 2018
|
@bastelfreak why? |
|
In general we always try to test against the latest ruby versions. We did those changes many time in the past as well (valid versions for travis are listed at http://rubies.travis-ci.org/ ). |
|
I do realize now that Puppet bundles a Ruby version. It might be good to match it exactly. |
|
@ekohl @bastelfreak IHMO puppet-agent AIO included/supported ruby and latest ruby would be good to test. unfortunatly the puppetserver ruby (jruby) is still on 1.9 level IMHO which would be important for serverside code (ruby parser functions mainly I think - as long as you use |
|
ah that vendor foo.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.