Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to count unreleased commits + cleanup #443

Merged
merged 6 commits into from
Jan 4, 2018

Conversation

bastelfreak
Copy link
Member

No description provided.

@@ -7,7 +7,7 @@ fi

version=$(git describe)
for module in modules/* ; do
pushd $module
pushd "$module" > /dev/null || exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about #!/bin/bash -e then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the || exit since that's what -e does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

#!/bin/bash

for module in modules/* ; do
pushd "$module" > /dev/null || exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using pushd you could also use git --git-dir I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

#!/bin/bash

for module in modules/* ; do
#pushd "$module" > /dev/null || exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bastelfreak bastelfreak merged commit 9b7c699 into voxpupuli:master Jan 4, 2018
@bastelfreak bastelfreak deleted the counter branch January 4, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants