-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to count unreleased commits + cleanup #443
Conversation
bin/create-pull-requests
Outdated
@@ -7,7 +7,7 @@ fi | |||
|
|||
version=$(git describe) | |||
for module in modules/* ; do | |||
pushd $module | |||
pushd "$module" > /dev/null || exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about #!/bin/bash -e
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the || exit since that's what -e
does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
bin/count-unreleased-commits
Outdated
#!/bin/bash | ||
|
||
for module in modules/* ; do | ||
pushd "$module" > /dev/null || exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than using pushd you could also use git --git-dir
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
bin/count-unreleased-commits
Outdated
#!/bin/bash | ||
|
||
for module in modules/* ; do | ||
#pushd "$module" > /dev/null || exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pushd/popd isn't defined in POSIX sh, so we need to use bash here
we run the script with bash -e, no need for || exit
No description provided.