Improve coveralls reporting #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves 2 issues. We use parallel_tests, so we should wait for simplecov to merge results before reporting to coveralls. We are reporting in two jobs, (once for puppet 4 and again for puppet 5). See: https://coveralls.zendesk.com/hc/en-us/articles/201769485-Ruby-Rails https://github.com/colszowka/simplecov#merging-results
|
As tested in voxpupuli/puppet-rabbitmq#636 |
|
looks good to me. Did you test it on any module? |
|
In puppet 4 job, no reporting to coveralls, but simplecov still writes to console. Compare to a previous PR puppet 5 job where 2 reports were sent... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves 2 issues.
We use parallel_tests, so we should wait for simplecov to merge
results before reporting to coveralls.
We are reporting in two jobs, (once for puppet 4 and again for
puppet 5).
See:
https://coveralls.zendesk.com/hc/en-us/articles/201769485-Ruby-Rails
https://github.com/colszowka/simplecov#merging-results