Ignore Guardfile when doing rubocop checks #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We ship Guardfiles in multiple repos. Should we put them in the .gitignore or should we manage it via modulesync? |
|
.gitignore . Definitely don't manage via modulesync. |
|
Can you update the moduleroot/.gitignore to also list the Guardfile? |
- Also add Guardfiles to .gitignore
juniorsysadmin
force-pushed
the
ignore-guardfile
branch
from
7a76a4a to
edaefb9
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style/FileName: The name of this source file (Guardfile) should use snake_caseGuardfiles are really a personal preference thing and shouldn't be synced or checked