Improve simplecov #272
Merged
Improve simplecov #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't run simplecov at all if the module has no `lib` directory. This should fix a github coveralls integration issue. Coveralls seems to get upset and never reports back to travis if we send it reports about 0 files. Include all ruby files under `lib` in the coverage report, even those with 0% coverage.
|
Tested on puppet-zabbix (a module containing types/providers) and puppet-jira (one with no lib dir). |
|
@alexjfisher you might want to submit this patch to puppet-module-skeleton as well, everyone seems to be struggling with the right way to use simplecov. |
|
@rnelson0 Lets give it a few days first, in case any more tweaking is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run simplecov at all if the module has no
libdirectory.This should fix a github coveralls integration issue. Coveralls seems
to get upset and never reports back to travis if we send it reports
about 0 files.
Include all ruby files under
libin the coverage report, even thosewith 0% coverage.