Add docker nodesets for acceptance tests

[jskarpe]

No description provided.

[dhoppe]

I think we should concentrate on releases we are already using for Vagrant. For example CentOS 5 and Debian 6 are not used anymore and regarding Ubuntu we only support LTS releases.

I also think we should use an .erb template for the nodesets, because we might need to get different packages installed.

[bastelfreak]

Probably we should also add a comment into each file that it is managed by modulesync.

[jskarpe]

I'm fine with deprecating old distros, but I disagree that it should be templates. In my opinion the nodesets should be standardized, and any additional packages required can be installed using the acceptance test itself as Puppet code. (E.G adding package { 'git': ensure => present } in the test itself)

Doesn't seem to be comments in the other nodesets (or other files really) with regards to modulesync? It's not sufficient with the commit message from modulesync with gets displayed by GitHub?

[dhoppe]

This could be a good solution. @bastelfreak What do you think?

My bad. CentOS is not EOL until 2017-03-31. I just added some comments at the other nodesets to point to modulesync.

[dhoppe]

@yuav Could you please restore centos-511-x64.yml, add one for docker and copy the comments from the other nodesets?

I spoke to @bastelfreak and will merge your pr afterwards.

[jskarpe]

Fixed the CentOS-5 stuff. Why do we care about vim not understanding yml extension?

[dhoppe]

Please prepend:

---
# This file is managed via modulesync
# https://github.com/voxpupuli/modulesync
# https://github.com/voxpupuli/modulesync_config

[dhoppe]

Please append:

...
# vim: syntax=yaml

[dhoppe]

Because we use that for other files as well.

dhoppe@macbook ..cts/puppet/voxpupuli/modulesync_config (git)-[master] % find . -type f | xargs grep vim
./config_defaults.yml:# vim: syntax=yaml
./Gemfile:# vim: syntax=ruby
./managed_modules.yml:# vim: syntax=yaml
./moduleroot/Gemfile:# vim: syntax=ruby
./moduleroot/Rakefile:# vim: syntax=ruby
./moduleroot/spec/acceptance/nodesets/centos-511-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/centos-66-x64-pe.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/centos-66-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/centos-72-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/debian-78-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/debian-82-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/ubuntu-server-1204-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/ubuntu-server-1404-x64.yml:# vim: syntax=yaml
./moduleroot/spec/acceptance/nodesets/ubuntu-server-1604-x64.yml:# vim: syntax=yaml
./moduleroot/spec/classes/coverage_spec.rb:# vim: syntax=ruby
./moduleroot/spec/spec_helper.rb:# vim: syntax=ruby
./modulesync.yml:# vim: syntax=yaml
./Rakefile:# vim: syntax=ruby

[jskarpe]

I've updated as per requirements now, but let the record show I think this should be fixed in vim, not every single file that could possibly be edited by vim.