Use new key line over linenumber. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes where you can run into the error below. The puppet-lint deprecation http://github.com/rodjek/puppet-lint/pull/540 has been merged into master. According to rodjek/puppet-lint#539 it was meant to be added at version 3 but is now merged with 2.0.2. Thanks @Feandil for diagnosis. ``` rake aborted! KeyError: key{linenumber} not found /afs/cern.ch/user/s/straylen/.gem/ruby/bundler/gems/puppet-lint-32e93d43a3bf/lib/puppet-lint.rb:102:in `%' /afs/cern.ch/user/s/straylen/.gem/ruby/bundler/gems/puppet-lint-32e93d43a3bf/lib/puppet-lint.rb:102:in `format_message' /afs/cern.ch/user/s/straylen/.gem/ruby/bundler/gems/puppet-lint-32e93d43a3bf/lib/puppet-lint.rb:136:in `block in report' ```
|
I merged this because line has been present for a long time so it'll work for any version of puppet-lint >=1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes where you can run into the error below.
The puppet-lint deprecation
http://github.com/rodjek/puppet-lint/pull/540
has been merged into master.
According to
rodjek/puppet-lint#539
it was meant to be added at version 3 but is now merged
with 2.0.2.
Thanks @Feandil for diagnosis.