Remove some redundant requires from Rakefile #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these are in puppetlabs_spec_helper/rake_tasks.rb
|
For lack of ability to test this myself right now, got a link to a module with this trimmed file that tests properly? |
|
How about I tested by removing all those lines and confirming that I had 23 rake tasks with or without them in |
|
The latest version of |
|
I just tested this on puppet-zabbix, I get the same amount of rake tasks after applying your patch (42). |
bastelfreak
added a commit
to voxpupuli/puppet-zabbix
that referenced
this pull request
May 8, 2016
based on voxpupuli/modulesync_config#148 I got 42 rake tasks before and after the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these are in puppetlabs_spec_helper/rake_tasks.rb