Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modulesync version number to modules when updated #184

Closed
bbriggs opened this issue Jun 27, 2016 · 3 comments
Closed

Add modulesync version number to modules when updated #184

bbriggs opened this issue Jun 27, 2016 · 3 comments

Comments

@bbriggs
Copy link
Contributor

bbriggs commented Jun 27, 2016

In order to keep track of what version of modulesync was used on a given module, we should use a key/value pair somewhere in the repo's root that we can query. When paired with a version-bump script that keeps the msync version file in line with the tag/release version, this would be a more reliable method than depending on commit messages.

@rski
Copy link
Member

rski commented Jun 27, 2016

Seconded, mostly because I always forget to even mention it in the commit message.

@dhoppe
Copy link
Member

dhoppe commented Sep 17, 2016

Is not this already fixed via #193?

@bbriggs
Copy link
Contributor Author

bbriggs commented Sep 17, 2016

we merged a PR for this forever ago. We can close this.

On Sat, Sep 17, 2016 at 9:28 AM, Dennis Hoppe notifications@github.com
wrote:

Is not this already fixed via #193
#193?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#184 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACPdKw6AtWGO8453hdwoYx1qBSKMmPaFks5qq-sXgaJpZM4I_E17
.

@dhoppe dhoppe closed this as completed Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants