Skip to content

Commit

Permalink
Limit to known-good setups from acceptance tests
Browse files Browse the repository at this point in the history
For acceptance testing, we look into metadata.json for supported versions
of Puppet and operating systems, and for each combination try to execute
the acceptance test suites.

However, some combination depend on nonexistent packages, typically for a
recent version of Puppet on an old Linux distribution, or with an old
version of Puppet on a recent Linux distribution.

Instead of letting GitHub compute all possible matrix combinations, rely
on puppet_metadata to build the list of supported combinations.
  • Loading branch information
smortex committed Aug 12, 2021
1 parent 04e5522 commit 66fa47b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions moduleroot/.github/workflows/ci.yml.erb
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: <%= @configs['timeout_minutes'] %>
outputs:
beaker_setfiles: ${{ steps.get-outputs.outputs.beaker_setfiles }}
puppet_major_versions: ${{ steps.get-outputs.outputs.puppet_major_versions }}
puppet_unit_test_matrix: ${{ steps.get-outputs.outputs.puppet_unit_test_matrix }}
github_action_test_matrix: ${{ steps.get-outputs.outputs.github_action_test_matrix }}
env:
BUNDLE_WITHOUT: development:system_tests:release
steps:
Expand Down Expand Up @@ -63,8 +62,7 @@ jobs:
strategy:
fail-fast: false
matrix:
setfile: ${{fromJson(needs.setup_matrix.outputs.beaker_setfiles)}}
puppet: ${{fromJson(needs.setup_matrix.outputs.puppet_major_versions)}}
include: ${{fromJson(needs.setup_matrix.outputs.github_action_test_matrix)}}
<%- @configs['beaker_fact_matrix'].each do |option, values| -%>
<%= option %>:
<%- values.each do |value| -%>
Expand Down

0 comments on commit 66fa47b

Please sign in to comment.