Skip to content

Commit

Permalink
Removed update_common_tests as a dependency of the test rake task
Browse files Browse the repository at this point in the history
For quite while we've made the test rake task update the common test
suite every time it's run, to stop the test suite from becoming
out-of-date. However, the downside to this is that many pull requests
end up failing due to new tests in the common test suite, rather than
changes in the pull request itself.

I think it'd be best to manually update the common test suite in
future. It should make the test suite more reliable.
  • Loading branch information
iainbeeston committed Mar 3, 2017
1 parent 594d7ac commit d7151d0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ Rake::TestTask.new do |t|
t.test_files = FileList.new('test/*_test.rb')
end

task :test => :update_common_tests

task :default => :test

0 comments on commit d7151d0

Please sign in to comment.