Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --show_diff #27

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Add support for --show_diff #27

merged 2 commits into from
Jun 1, 2023

Conversation

smortex
Copy link
Member

@smortex smortex commented May 27, 2023

Some CI failures are easier to fix when we have a diff of changes (e.g.
when acceptance tests check for idempotentency and some changes happen).

Add support for the --show_diff parameter to enable it.

@smortex
Copy link
Member Author

smortex commented May 27, 2023

voxpupuli/puppet-borg#163 already attempts to use this parameter to fix the tests. I will switch to this branch there to make sure it works as expected. Switching to draft until this is 100% verified.

@smortex smortex marked this pull request as draft May 27, 2023 20:23
smortex added 2 commits May 27, 2023 10:39
Some CI failures are easier to fix when we have a diff of changes (e.g.
when acceptance tests check for idempotentency and some changes happen).

Add support for the `--show_diff` parameter to enable it.
@smortex
Copy link
Member Author

smortex commented May 27, 2023

Its alive!

screenshot of GitHub action with a diff

@smortex smortex marked this pull request as ready for review May 27, 2023 20:56
@bastelfreak bastelfreak added the enhancement New feature or request label May 27, 2023
@bastelfreak bastelfreak merged commit 2bfedbc into master Jun 1, 2023
@bastelfreak bastelfreak deleted the show_diff branch June 1, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants